Remove the capture_disjoint_fields feature
#108550
Merged
+17
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
I don't think we ever plan on enabling this for editions < 2021, and only nightly(or bootstrap) users are able to use it anyways. Therefore I think this is totally fine to remove. I don't think this needs an FCP or anything, since the feature was already stabilized for edition 2021+, but cc @rust-lang/lang for good measure. This is a small PR and can be reverted just in case I'm totally misunderstanding the process here. r? @compiler-errors @bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 28, 2023
…ler-errors Remove the `capture_disjoint_fields` feature As best I can tell, this was stabilized for Edition 2021 in rust-lang#88126 but the feature was never removed.
|
This makes perfect sense to me, @compiler-errors 👍 And in general I'd say compiler's always allowed to remove nightly-only stuff it deems not useful enough to keep maintaining. |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Feb 28, 2023
…ler-errors Remove the `capture_disjoint_fields` feature As best I can tell, this was stabilized for Edition 2021 in rust-lang#88126 but the feature was never removed.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 28, 2023
…ler-errors Remove the `capture_disjoint_fields` feature As best I can tell, this was stabilized for Edition 2021 in rust-lang#88126 but the feature was never removed.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 1, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#108297 (Exit when there are unmatched delims to avoid noisy diagnostics) - rust-lang#108531 (rustdoc: Show that repeated expression arrays can be made with constant values) - rust-lang#108536 (Update books) - rust-lang#108550 (Remove the `capture_disjoint_fields` feature) - rust-lang#108551 (Descriptive error when users try to combine RPITIT/AFIT with specialization) - rust-lang#108554 (Only look for param in item's generics if it actually comes from generics) - rust-lang#108555 (Fix a race in the query system) - rust-lang#108558 (add missing feature in core/tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As best I can tell, this was stabilized for Edition 2021 in #88126 but the feature was never removed.